flatsurf / e-antic

Embedded algebraic number fields
https://flatsurf.github.io/e-antic/libeantic/
GNU Lesser General Public License v3.0
12 stars 11 forks source link

source tarball contains dead links #189

Closed jgmbenoit closed 2 years ago

jgmbenoit commented 3 years ago

It appears that the source tarball contains dead links in libeantic/upstream/patched : please consider to provide the original sources not the their links.

saraedum commented 3 years ago

@jgmbenoit sorry, I am not sure which tarball you are referring to. The one on the releases page here called e-antic-1.0.1.tar.gz does not seem to contain any symlinks. Could you clarify?

jgmbenoit commented 3 years ago

At the release page, the explicit source ball contains indeed no orphan links. However, at the same page, the Source Code tarball contains orphan links in libeantic/upstream/patched .

saraedum commented 3 years ago

I see. The source code tarball is created automatically by github from the release tag. I don't think I can edit it. Since it does not pull in submodules, it is missing lots of files actually. I don't think we can do anything about it unfortunately, https://github.community/t/create-release-that-contains-submodule/1329.

I will close this issue since github is broken by design here it appears. I am happy to reopen this one if I missed something of course.

jgmbenoit commented 2 years ago

Okay, I have to play with the explicit source ball. I have just noticed that it does not contain the doc material. Can you provide it ?

jgmbenoit commented 2 years ago

It also appears that the map files are actually missing in the explicit source ball.

saraedum commented 2 years ago

I pushed the doc/ problem out to #231.

The doc/ is probably not terribly useful for Debian yet (if that's the use case) since you need an unreleased version of standardese to be actually able to build it.

saraedum commented 2 years ago

The missing version scripts should be fixed in #232.