search

flatsurf / e-antic

Embedded algebraic number fields
https://flatsurf.github.io/e-antic/libeantic/
GNU Lesser General Public License v3.0
12 stars 11 forks source link

Fix conversions when the generator is not x #196

Closed saraedum closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #196 (72e216d) into master (139615e) will increase coverage by 0.04%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
+ Coverage   92.05%   92.10%   +0.04%     
==========================================
  Files         105      105              
  Lines        2052     2052              
==========================================
+ Hits         1889     1890       +1     
+ Misses        163      162       -1
Impacted Files Coverage Δ
libeantic/e-antic/renf_class.hpp 100.00% <0.00%> (+50.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 139615e...72e216d. Read the comment docs.

slel commented 3 years ago

Can you also help with these possibly similar issues? : )

Fix JacobianMorphism_divisor_class_field crash when variable name is not x https://trac.sagemath.org/ticket/30087

Behaviour of projective curves over QQbar depend on indeterminate names https://trac.sagemath.org/ticket/32077

saraedum commented 3 years ago

I don't think they are related.