search

flatsurf / e-antic

Embedded algebraic number fields
https://flatsurf.github.io/e-antic/libeantic/
GNU Lesser General Public License v3.0
12 stars 11 forks source link

Hint at non-standard header location for Fedora #207

Closed saraedum closed 3 years ago

saraedum commented 3 years ago

fixes #200

codecov[bot] commented 3 years ago

Codecov Report

Merging #207 (97f54ff) into master (81ff664) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #207   +/-   ##
=======================================
  Coverage   92.10%   92.10%           
=======================================
  Files         105      105           
  Lines        2052     2052           
=======================================
  Hits         1890     1890           
  Misses        162      162

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 81ff664...97f54ff. Read the comment docs.

saraedum commented 3 years ago

@videlec does this look good to you?

videlec commented 3 years ago

Looks good. Is this the kind of things that should appear in the installation guide? For example, in the README we already talk about CPPFLAGS and LDFLAGS.

saraedum commented 3 years ago

I don't think we need to extend the README. The very few people affected (those building from source on Fedora) can hopefully understand the error message.