flatsurf / e-antic

Embedded algebraic number fields
https://flatsurf.github.io/e-antic/libeantic/
GNU Lesser General Public License v3.0
12 stars 11 forks source link

Do not assume that _cmp functions return -1, 0, 1 #220

Closed saraedum closed 2 years ago

saraedum commented 2 years ago

Fixes #194, #211.

codecov[bot] commented 2 years ago

Codecov Report

Merging #220 (84304db) into master (ecd288f) will increase coverage by 0.05%. The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
+ Coverage   92.10%   92.16%   +0.05%     
==========================================
  Files         105      105              
  Lines        2053     2055       +2     
==========================================
+ Hits         1891     1894       +3     
+ Misses        162      161       -1     
Impacted Files Coverage Δ
libeantic/e-antic/renf_elem.h 100.00% <ø> (ø)
libeantic/src/fmpz_poly_extra/bisection_step_arb.c 76.66% <ø> (ø)
libeantic/srcxx/renf_elem_class.cpp 97.69% <87.50%> (ø)
libeantic/src/renf_elem/fdiv.c 71.79% <100.00%> (+4.22%) :arrow_up:
libeantic/src/renf_elem/get_d.c 98.21% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ecd288f...84304db. Read the comment docs.