flatsurf / e-antic

Embedded algebraic number fields
https://flatsurf.github.io/e-antic/libeantic/
GNU Lesser General Public License v3.0
12 stars 11 forks source link

Make e-antic pip-installable #222

Closed saraedum closed 2 years ago

saraedum commented 2 years ago

Checklist

Dependencies

codecov[bot] commented 2 years ago

Codecov Report

Merging #222 (18c9aa7) into master (20cfd19) will decrease coverage by 0.04%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
- Coverage   92.05%   92.00%   -0.05%     
==========================================
  Files         105      105              
  Lines        2064     2064              
==========================================
- Hits         1900     1899       -1     
- Misses        164      165       +1     
Impacted Files Coverage Δ
libeantic/e-antic/renf_class.hpp 50.00% <0.00%> (-50.00%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 20cfd19...18c9aa7. Read the comment docs.

saraedum commented 2 years ago

We probably don't want to do this anymore. Instead, the current thinking is that we should try to make our SPKGs work and then cibuildwheel with SageMath in the same way that https://trac.sagemath.org/ticket/31588 is planning to.