flatsurf / e-antic

Embedded algebraic number fields
https://flatsurf.github.io/e-antic/libeantic/
GNU Lesser General Public License v3.0
12 stars 11 forks source link

Still needed in 1.1.0 #230

Closed w-bruns closed 2 years ago

w-bruns commented 2 years ago

The Normaliz installation script for e-aqntic contains the lines

sed -i -e s/fmpq_poly_add_fmpq/fmpq_poly_add_fmpq_eantic/g upstream/patched/fmpq_poly_add_fmpq.c
sed -i -e s/fmpq_poly_add_fmpq/fmpq_poly_add_fmpq_eantic/g upstream/patched/nf_elem_add_fmpq.c

Are they still needed in 1.1.0?

saraedum commented 2 years ago

If you want to build statically, this is still needed I think. Otherwise, it's not needed.

Otherwise, these don't depend on the version of e-antic but on the version of its dependencies, namely that patch is not needed if FLINT is at least 2.8.4 (the latest release) but there is no flag to disable the patch in that case yet.