Closed saraedum closed 2 years ago
The hp and vp in this example were: (0, 2, 1) (1, 0, 2)
0 is indeed not allowed.
IntegerVectors
output vector with zero entries unless we set min_part=1
.
Ok, let me see if I can fix this myself then.
I pushed something. This should be fixed with fd56ecb.
I don't think that's the issue here actually. The first parameters have zeros, i.e., the r_tuple
and u_tuple
in yield ThurstonVeech(o.r_tuple(), o.u_tuple(), mh, mv)
Oh, these are just permutations. So the zeros should be alright actually…hm…
Maybe there's something missing in the latest released surface dynamics after all?
So the permutation is expected to be encoded as cycles but is encoded as a single tuple. I think I know how to fix this.
Now the code is zero based everywhere (see 9d45045). Though the sage-flatsurf construction could be more flexible https://github.com/flatsurf/sage-flatsurf/issues/133
All thurston veech runs currently fail with:
This one for example comes from the invocation: