Shortcut in subfield - Githubissues

flatsurf / sage-flatsurf

Flat surfaces in Sage

https://flatsurf.github.io/sage-flatsurf/

GNU General Public License v2.0

10 stars 10 forks source link

Closed videlec closed 2 years ago

videlec commented 2 years ago

Fixes #139.

provide a shortcut in subfield_from_elements when one of the generator has the degree of the ambient number field
try to call less often the FreeModule.subspace method which calls the expensive echelonization over the rationals
chase denominators before saturation by multiplication

videlec commented 2 years ago

Great. Should I add a benchmark for this?

Yes. Why not.

saraedum commented 2 years ago

Ok. Then I'll add the full asv benchmark setup here that we have in the other projects.

saraedum commented 2 years ago

Fails because of https://github.com/conda-forge/normaliz-feedstock/pull/35. (Mismatch in Arb versions that we have available.)