search

flatsurf / sage-flatsurf

Flat surfaces in Sage
https://flatsurf.github.io/sage-flatsurf/
GNU General Public License v2.0
10 stars 10 forks source link

Implement Iso Delaunay Tessellation #163

Open sfreedman67 opened 2 years ago

sfreedman67 commented 2 years ago

fixes #160

saraedum commented 1 year ago

@sfreedman67 the output for the prym3 example has changed. It now looks like this:

image

I have no idea what it looked like before but the doctest is failing because there are now 218 graphic primitives instead of 110. Maybe the plotting has just changed and everything is plotted twice somehow.

Just wondering if you spot anything here that looks obviously wrong.

saraedum commented 1 year ago

@sfreedman67 I'll remove the spine stuff again from this PR. It's not going to happen that quickly and we should not expand the scope of this one if possible.

github-actions[bot] commented 1 year ago

Documentation preview for this PR is ready! :tada: Built with commit: 85487232312e4366b05f773d2001f8d782c06d72

videlec commented 4 months ago

We are working with a student (Oscar) on using iso-Delaunay and spine to list more efficiently saddle connections. Right now, the code in the branch does not really makes the distinction between

sfreedman67 commented 4 months ago

That sounds like an interesting use case for the iso-Delaunay tessellation! Making IsoDelaunayTessellation the former would be consistent with Bowman’s paper.

Are there still plans to implement the Veech group element discovery portion of the code?

On Apr 25, 2024, at 9:07 AM, Vincent Delecroix @.***> wrote:

We are working with a student (Oscar) on using iso-Delaunay and spine to list more efficiently saddle connections. Right now, the code in the branch does not really makes the distinction between

the tessellation of $\mathbb{H}^2$ which always have infinitely many regions the tessellation of $\mathbb{H}^2 / \Gamma$ To me the IsoDelaunayTessellation should be the first of the two. The fact that it could be used to discover elements in the Veech group is definitely an important feature. But to my mind it would be better not to force such check for each face exploration. — Reply to this email directly, view it on GitHub https://github.com/flatsurf/sage-flatsurf/pull/163#issuecomment-2077138527, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQGU3UTRQAFJS5E3YGIXJO3Y7D5YJAVCNFSM5UPKMIDKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBXG4YTGOBVGI3Q. You are receiving this because you were mentioned.

videlec commented 4 months ago

Are there still plans to implement the Veech group element discovery portion of the code?

Yes. This is another important motivation! But for that purpose I would implement a different explore (or possibly a flexible one that supports many usage).

videlec commented 4 months ago

Also, it feels like the IsoDelaunayTessellation._dual_graph would better be implemented as an "embedded graph" rather than just a graph. Namely, we want to record the cyclic ordering of edges around the region.