search

flatsurf / sage-flatsurf

Flat surfaces in Sage
https://flatsurf.github.io/sage-flatsurf/
GNU General Public License v2.0
10 stars 10 forks source link

Support angles greater 2π in EquiangularPolygons #170

Open saraedum opened 2 years ago

videlec commented 2 years ago

Even though it works in some cases, going via EquiangularPolygons will not generalize well (because two boundaries could give rise to two different flat disks).

davidaulicino commented 2 years ago

I think it's great that it can handle any polygons with angle greater than 2pi. Do you have any idea of the scope of it's functionality at the moment? Can it handle all polygons with one angle larger than 2pi? Does a problem arise when you get to 7-gons and an angle greater than 4pi is possible?

saraedum commented 2 years ago

This is only a hack to show that the approach we discussed works in principle. This still needs some architectural work the result might be that EquiangularPolygons is the wrong place.

I would imagine that an angle >4pi is easier than two angles >2pi but I have not tried.

github-actions[bot] commented 1 year ago

Documentation preview for this PR is ready! :tada: Built with commit: 3301595ec24f6a4c231c62938a060cbfcca6cbdf