search

flatsurf / sage-flatsurf

Flat surfaces in Sage
https://flatsurf.github.io/sage-flatsurf/
GNU General Public License v2.0
10 stars 10 forks source link

Drop deprecated functions #197

Closed saraedum closed 1 year ago

saraedum commented 1 year ago

I wanted to replace the SageMath deprecation warnings in the code with generic Python warnings so that the warnings do not link to trac tickets that are unrelated/don't exist anymore. I considered using a library such as Deprecated or deprecation but it turns out that these don't play nicely with SageMath's doctesting framework.

Anyway, actually all the deprecated functionality has been deprecated for at least 3 years, so I guess we can just drop it anyway. That's what I ended up doing. In the future we should not abuse sage.misc.superseded anymore but just

from warnings import warn
warn("Class.method() has been deprecated and will be removed from a future version of sage-flatsurf. Use somethingelse() instead. See https://github.com/flatsurf/sage-flatsurf/issues/123.")
saraedum commented 1 year ago

@videlec @slel please have a look if we want to keep any of this deprecated functionality.