Fix caching for mutable surfaces

flatsurf / sage-flatsurf

Flat surfaces in Sage

https://flatsurf.github.io/sage-flatsurf/

GNU General Public License v2.0

10 stars 10 forks source link

Fix caching for mutable surfaces #290

Closed saraedum closed 1 week ago

saraedum commented 2 weeks ago

we must not cache anything for surfaces that are mutable. However, once a surface becomes immutable, we enable caching which is as fast as SageMath's native cached method.

We checked with %timeit that this approach does the trick.

Checklist

[x] Added an entry in doc/news/.
[x] Added a test for this change.
[x] Added new .py files to the documentation in doc/geometry or doc/graphical.

github-actions[bot] commented 2 weeks ago

Documentation preview for this PR is ready! :tada: Built with commit: 6338244259c195051c5c3b171f3dd4aa98873303

saraedum commented 1 week ago

@videlec I hope you agree that this is a nice feature and not too crazy a hack :)