flatsurf / surface-dynamics

Teichmüller dynamics in SageMath
https://flatsurf.github.io/surface-dynamics/
GNU General Public License v2.0
12 stars 14 forks source link

Fat graphs behave badly when not connected #68

Open videlec opened 1 year ago

videlec commented 1 year ago
from surface_dynamics import FatGraph
fg = FatGraph('(0,1)(2,3)', '(0,1)(2,3)')
fg.genus()

gives -1 (but it is two genus 0 components)

fchapoton commented 1 year ago

so this should be closed now ?

saraedum commented 2 weeks ago

I guess, but the example actually gives product is not identity now @videlec .

videlec commented 2 weeks ago

The input format has changed as well as the output of fg.genus()

sage: fg = FatGraph('(0,1)(2,3)')
sage: fg.genus()
0
sage: fg.is_connected()
False

It is not clear to me whether genus() would better raise an error for disconnected surface.