search

flatsurf / surface-dynamics

Teichmüller dynamics in SageMath
https://flatsurf.github.io/surface-dynamics/
GNU General Public License v2.0
11 stars 13 forks source link

Fix CI #9

Closed saraedum closed 3 years ago

saraedum commented 3 years ago

cython does not seem to pick up the CPPFLAGS, but it should: https://github.com/python/cpython/blob/33986465bde2a2188537c4ef6cdb6055e348f31f/Lib/distutils/sysconfig.py#L223

But it only uses them for C compilation not for C++ …

saraedum commented 3 years ago

(curious, that this has been reported 15 years ago upstream and is still open…wontfix rather)

saraedum commented 3 years ago

Seems I've been barking up the wrong tree here. The CXXFLAGS are picked up but just weren't set.

saraedum commented 3 years ago

This mostly works. Are the sage-flatsurf errors expected?

videlec commented 3 years ago

Nope :) Let me fix them here.

videlec commented 3 years ago

The issue comes from the following which seems not be supported in the CI setup (but it is with the sage-flatsurf available in conda)

sage: from flatsurf import ConvexPolygons 
sage: ConvexPolygons(ZZ)
ConvexPolygons(Integer Ring)

EDIT: not sure it is the case actually. In my conda environment the line with sage-flatsurf appears as

sage-flatsurf             0.3                      pypi_0    pypi

Indeed, with the version from PyPI it fails.

videlec commented 3 years ago

Many thanks for your help.