search

flattenthecurve / guide

https://www.flattenthecurve.com
Creative Commons Attribution 4.0 International
38 stars 33 forks source link

New Homepage #254

Closed emersonthis closed 4 years ago

emersonthis commented 4 years ago

(Mostly) closes #213

Done

TODO

Screen Shot 2020-03-26 at 9 43 15 PM

Follow-up issues

github-actions[bot] commented 4 years ago

Deploy preview for website ready!

Built with commit 58a6ea7998af3a636cd3752088e48b88c901f5c6

https://guide-preview-6b2t48czy.now.sh

mverzilli commented 4 years ago

Looks great overall! Just a couple of comments below, mostly around follow up issues:

Add Ivan's jazzy new logo

Let's park this for another time. Two reasons:

  1. I'm a bit concerned about impacting readability.
  2. Changing the logo is something most of the org has to be onboard with. I don't see a need to make that change at the same time as this homepage overhaul. Let's leave it out so we reduce the list of issues we need to resolve before releasing.

Move "contribute" out of the primary nav (into footer)

Can we leave it in both places for now? Or there was a broad discussion on removing Contribute from the navigation header and I missed it?

Rename /act_and_prepare permalink to match new page title (what-do-do)?

Ideally we should keep both, what-to-do for consistency and act_and_prepare links into it around the internet can still reach the page. Someone should check Jekyll to see how it can get done. Nice catch raising up this issue!

weltyj commented 4 years ago

@emersonthis @mverzilli I looked at all the languages on my little cellphone -- all menus function in all languages. Looks good to go from that standpoint

One bad image link I found. Simple edit in _sections/COVID-19/en/06-keep-the-main-thing-the-main-thing.md This link needs a leading "/" (like so) ![](/images/health-system-capacity.svg)

emersonthis commented 4 years ago

Sorry for the confusion about “contribute”... I meant “contact” which I think was discussed with Nico last week.

About the list of future issues... I included those mostly to indicate things I knowingly did not include in this PR (and don’t plan to). So of course we can hold off on any of them, like the logo, etc

On Mar 27, 2020, at 7:21 AM, weltyj notifications@github.com wrote:

 @emersonthis @mverzilli I looked at all the languages on my little cellphone -- all menus function in all languages. Looks good to go from that standpoint

One bad image link I found. Simple edit in _sections/COVID-19/en/06-keep-the-main-thing-the-main-thing.md This link needs a leeding "/" (like so)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

weltyj commented 4 years ago

Oops, I found two more image links needing a leading slash in _sections/COVID-19/en/05-this-is-not-normal-flu.md

weltyj commented 4 years ago

I confess I'm at the limit of my git understanding. There maybe a better way to do this, but I pulled the issue-213 branch and made the small edits to correct the image links -- and create a "en" directory in _sections/04-about/ . I also just now (11:49am PT) auto-corrected the *.md files within a directory to make sure only 1 '#' exists per directory (many files in many directories in other languages affected).

I made a new branch with my edits. I DID NOT create a PR for this in order to avoid confusion. @emersonthis @mverzilli here is the branch:

https://github.com/flattenthecurve/guide/tree/jw-edits-issue-213

weltyj commented 4 years ago

@mverzilli @emersonthis
Ideally we should keep both, what-to-do for consistency and act_and_prepare links into it around the internet can still reach the page. Someone should check Jekyll to see how it can get done. Nice catch raising up this issue!

^^^ I'll check into that. I suggest releasing the homepage as is (with my branch I mentioned above) since we know it works.

I found this: https://blog.webjeda.com/jekyll-redirect/

Looks like there is a jekyll redirect plugin that can send an http 301 to the browser. So in theory, add the redirect plugin to _config.yml, rename the -act-and-prepare directory and the act-and-prepare-??.md files. The english markdown file would look like:

`--- layout: page_with_toc toc: true title: What to do permalink: /what-to-do/ redirect_from: --/act-and-prepare/ lang: en order: 1 translate_content: false

{% render_section what_to_do %} `

emersonthis commented 4 years ago

I just merged @weltyj 's changes into this branch. That seems to have resolved the broken images and updated the other language versions touched by this. Anything left to solve before this can get merged?

weltyj commented 4 years ago

@mverzilli @bcardiff @emersonthis I would add a review approval, but it doesn't seem to meet the intention of the approval process since my edits are now part of the branch. If you think it's ok for me to approve I will.

emersonthis commented 4 years ago

@mverzilli @nditada does this still need the “do not merge” label? I think everything mentioned above has been addressed. Let me know if there’s anything left for me to do on this.

mverzilli commented 4 years ago

Given how critical this change is, I've asked the other team leaders to confirm they're ok with the change as seen in the preview. Once they 👍 and you fix this link I'll merge. Amazing work @emersonthis 🙇

weltyj commented 4 years ago

https://github.com/flattenthecurve/guide/tree/issue-213-fix-dont-link @emersonthis @mverzilli

Early riser here :-) That fixes the broken link which was pointing to #dont, needed to be #do-not in _sections/home/01-site-header.md

emersonthis commented 4 years ago

@mverzilli The link is fixed

mverzilli commented 4 years ago

Awesome! The only remaining bit to solve is what to do with the "STAY INFORMED" section. I'm raising that issue and will get to you as soon as I have further direction from core team. Sorry I didn't realize about that gap before :/

emersonthis commented 4 years ago

@mverzilli can you say a bit more about “the problem” that needs to be solved? I wasn’t aware there is an issue. Maybe we can propose solutions?