Fix language attribute on homepage

flattenthecurve / guide

https://www.flattenthecurve.com

Creative Commons Attribution 4.0 International

38 stars 33 forks source link

Fix language attribute on homepage #297

Closed emersonthis closed 4 years ago

emersonthis commented 4 years ago

Closes #284

This was originally reported as an issue with Greek, but it turns out this was actually an issue for all the languages besides English. Thanks to good research by @mpitid the root cause was that the hompage layout was not set up in a way that the lang attribute was being set correctly.

This should be reviewed by someone familiar with the localization infrastructure before merging...

Before

After

github-actions[bot] commented 4 years ago

This pull request is being automatically deployed with now-deployment

Built with commit 61dc73611f5f14ab75166a23bb0b8f8280e026c8

✅ Preview: https://guide-preview-iv2q7g6bx.now.sh

mpitid commented 4 years ago

Just to confirm, will the front matter be updated if the title changes in Lokalise, or if a new language gets added?