flattenthecurve / guide

https://www.flattenthecurve.com
Creative Commons Attribution 4.0 International
38 stars 33 forks source link

Navigation breakpoints don't "fit" for Greek and Russian #298

Open emersonthis opened 4 years ago

emersonthis commented 4 years ago

Bug: The breakpoint that determines when the navigation gets hidden behind the hamburger works for English and the romance languages. But the words are longer for Greek and Russian, so there's an awkward overlap on "in between" size screens (tablets, etc)

Screen Shot 2020-04-04 at 5 40 13 PM Screen Shot 2020-04-04 at 5 41 07 PM

Suggested fix: The easy (read: lazy) solution would be to just set this $on-tablet breakpoint higher. But this will effect a lot of other styles, so I don't recommend it.

A better solution would be to coordinate with translators to maybe choose shorter words for the nav, if there are acceptable synonyms.

It would also be ideal for the nav to be implemented in a way that's more resilient, and fails more gracefully. The overlapping is the result of absolute positioning, which tends to be problematic and hard to maintain. Maybe we could redo it using flexbox or a different strategy that perhaps results in text wrapping when it doesn't fit (instead of overlapping in an unusable way).