Incorrect lang attribute on Resources page

Bug: We noticed this exact same problem on the homepage: #284 The language buttons work but the page's lang attribute does not change from en. This matters because CSS needs this to know how to correctly format accents, etc for certain languages (like Greek).

Suggested fix: We solved this exact issue on the homepage in this PR: #297 . I suspect the identical refactor needs to happen for the resources page:

create a new file for each translation with the corresponding language suffix (ex: resources-it.md)
Update the yaml at the top of each version of the file to include the correct lang value (ex: 'it') and also the title value should be in the same language if we want the html to be translated.</li> </ul> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/rousik"><img src="https://avatars.githubusercontent.com/u/7414040?v=4" />rousik</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>Note that we don't localize Resources pages so it's always in English, which means that we can expect to see mixed-language pages here.</p> <p>Do you know what's the right approach in such situation?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/emersonthis"><img src="https://avatars.githubusercontent.com/u/1728139?v=4" />emersonthis</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>I should think about this more, but my first quick thought is that we should use the yaml attributes at the top of each resource entry to specify the language, then set the lang attribute accordingly on each entry. That we could have an entry that’s for Greece, written in Greek, and we won’t have typography problems. </p> <p>Another option is to just write all the resources in English since they’re mostly external links anyway. If we’re resolved not to localize this page, this may be the best answer.</p> <blockquote> <p>On Apr 24, 2020, at 11:11 AM, Jan Rous <a href="mailto:notifications@github.com">notifications@github.com</a> wrote:</p> <p> Note that we don't localize Resources pages so it's always in English, which means that we can expect to see mixed-language pages here.</p> <p>Do you know what's the right approach in such situation?</p> <p>— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.</p> </blockquote> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/rousik"><img src="https://avatars.githubusercontent.com/u/7414040?v=4" />rousik</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>The entries are all in English as of today.</p> <p>On Fri, Apr 24, 2020, 13:06 emersonthis <a href="mailto:notifications@github.com">notifications@github.com</a> wrote:</p> <blockquote> <p>I should think about this more, but my first quick thought is that we should use the yaml attributes at the top of each resource entry to specify the language, then set the lang attribute accordingly on each entry. That we could have an entry that’s for Greece, written in Greek, and we won’t have typography problems.</p> <p>Another option is to just write all the resources in English since they’re mostly external links anyway. If we’re resolved not to localize this page, this may be the best answer.</p> <blockquote> <p>On Apr 24, 2020, at 11:11 AM, Jan Rous <a href="mailto:notifications@github.com">notifications@github.com</a> wrote:</p> <p> Note that we don't localize Resources pages so it's always in English, which means that we can expect to see mixed-language pages here.</p> <p>Do you know what's the right approach in such situation?</p> <p>— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.</p> </blockquote> <p>— You are receiving this because you commented. Reply to this email directly, view it on GitHub <a href="https://github.com/flattenthecurve/guide/issues/304#issuecomment-619191262">https://github.com/flattenthecurve/guide/issues/304#issuecomment-619191262</a>, or unsubscribe <a href="https://github.com/notifications/unsubscribe-auth/ABYSCGAMPTDGLM54FESDV53ROHPLRANCNFSM4MBGZV4Q">https://github.com/notifications/unsubscribe-auth/ABYSCGAMPTDGLM54FESDV53ROHPLRANCNFSM4MBGZV4Q</a> .</p> </blockquote> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/rousik"><img src="https://avatars.githubusercontent.com/u/7414040?v=4" />rousik</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>I don't think we have mechanism in place to translate these and no plans to translate them as of today so we can assume that the page will be in English, possibly with the header/intro section translated?</p> <p>It seems technically feasible to translate these but I'm not sure if it's worth our energy and possibly limited translation bandwidth to focus on that.</p> <p>So until things change, let's assume this is always English.</p> <p>On Fri, Apr 24, 2020, 13:08 Jan Rouš <a href="mailto:rousik@gmail.com">rousik@gmail.com</a> wrote:</p> <blockquote> <p>The entries are all in English as of today.</p> <p>On Fri, Apr 24, 2020, 13:06 emersonthis <a href="mailto:notifications@github.com">notifications@github.com</a> wrote:</p> <blockquote> <p>I should think about this more, but my first quick thought is that we should use the yaml attributes at the top of each resource entry to specify the language, then set the lang attribute accordingly on each entry. That we could have an entry that’s for Greece, written in Greek, and we won’t have typography problems.</p> <p>Another option is to just write all the resources in English since they’re mostly external links anyway. If we’re resolved not to localize this page, this may be the best answer.</p> <blockquote> <p>On Apr 24, 2020, at 11:11 AM, Jan Rous <a href="mailto:notifications@github.com">notifications@github.com</a> wrote:</p> <p> Note that we don't localize Resources pages so it's always in English, which means that we can expect to see mixed-language pages here.</p> <p>Do you know what's the right approach in such situation?</p> <p>— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.</p> </blockquote> <p>— You are receiving this because you commented. Reply to this email directly, view it on GitHub <a href="https://github.com/flattenthecurve/guide/issues/304#issuecomment-619191262">https://github.com/flattenthecurve/guide/issues/304#issuecomment-619191262</a>, or unsubscribe <a href="https://github.com/notifications/unsubscribe-auth/ABYSCGAMPTDGLM54FESDV53ROHPLRANCNFSM4MBGZV4Q">https://github.com/notifications/unsubscribe-auth/ABYSCGAMPTDGLM54FESDV53ROHPLRANCNFSM4MBGZV4Q</a> .</p> </blockquote> </blockquote> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/emersonthis"><img src="https://avatars.githubusercontent.com/u/1728139?v=4" />emersonthis</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>I still think we need to fix the lang attribute on the HTML tag so that the menu works correctly for all languages. But maybe we just wrap the main content in a lang=en-us and be done with it.</p> <blockquote> <p>On Apr 24, 2020, at 12:08 PM, Jan Rous <a href="mailto:notifications@github.com">notifications@github.com</a> wrote:</p> <p> The entries are all in English as of today.</p> <p>On Fri, Apr 24, 2020, 13:06 emersonthis <a href="mailto:notifications@github.com">notifications@github.com</a> wrote:</p> <blockquote> <p>I should think about this more, but my first quick thought is that we should use the yaml attributes at the top of each resource entry to specify the language, then set the lang attribute accordingly on each entry. That we could have an entry that’s for Greece, written in Greek, and we won’t have typography problems.</p> <p>Another option is to just write all the resources in English since they’re mostly external links anyway. If we’re resolved not to localize this page, this may be the best answer.</p> <blockquote> <p>On Apr 24, 2020, at 11:11 AM, Jan Rous <a href="mailto:notifications@github.com">notifications@github.com</a> wrote:</p> <p> Note that we don't localize Resources pages so it's always in English, which means that we can expect to see mixed-language pages here.</p> <p>Do you know what's the right approach in such situation?</p> <p>— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.</p> </blockquote> <p>— You are receiving this because you commented. Reply to this email directly, view it on GitHub <a href="https://github.com/flattenthecurve/guide/issues/304#issuecomment-619191262">https://github.com/flattenthecurve/guide/issues/304#issuecomment-619191262</a>, or unsubscribe <a href="https://github.com/notifications/unsubscribe-auth/ABYSCGAMPTDGLM54FESDV53ROHPLRANCNFSM4MBGZV4Q">https://github.com/notifications/unsubscribe-auth/ABYSCGAMPTDGLM54FESDV53ROHPLRANCNFSM4MBGZV4Q</a> .</p> <p>— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.</p> </blockquote> </blockquote> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

flattenthecurve / guide

Incorrect lang attribute on Resources page #304