search

flattenthecurve / guide

https://www.flattenthecurve.com
Creative Commons Attribution 4.0 International
38 stars 33 forks source link

Resource script improvements #305

Closed rousik closed 4 years ago

rousik commented 4 years ago

Few improvements to the resource import process.

  1. use yaml.dump to properly escape the attributes for each resource
  2. use lowercase url so that it is consistent with the column name and doesn't need special treatment (subsequent change to resources.md and regen of existing resource will be part of a separate PR)
  3. Added --clobber flag that skips over already existing resource files by default
github-actions[bot] commented 4 years ago

This pull request is being automatically deployed with now-deployment

Built with commit c0f2bbec95372dc6e0bad5e04a388e1f8faf92f1

✅ Preview: https://guide-preview-dfb65ssec.now.sh

rousik commented 4 years ago

@jaysonvirissimo and @emersonthis for reviews

emersonthis commented 4 years ago

This all makes sense to me and I don't see anything problematic, but I haven't written any python for over a decade and I don't have any background knowledge about how the script works... so I don't feel qualified to provide an effective.

jaysonvirissimo commented 4 years ago

@rousik: I'm also not a Python dev, but the basic idea LGTM. I approve, but can't GitHub Approve™, since I don't have repo permissions 😆.