search

flattenthecurve / guide

https://www.flattenthecurve.com
Creative Commons Attribution 4.0 International
38 stars 33 forks source link

Fixes to the resource page #306

Closed rousik closed 4 years ago

rousik commented 4 years ago

This is a second part of https://github.com/flattenthecurve/guide/pull/305 (should be only integrated once the other PR is in).

This PR:

  1. switches to lowercase url attribute for resources (to eliminate need for special treatments)
  2. properly escapes all resource attributes & removes some ad-hoc empty lines in the resource files
  3. Converts United States to USA in one of the resource files. [1]

[1] it might be worth creating automatic rule converting the country name to the canonical form when new resource submission is received.

github-actions[bot] commented 4 years ago

This pull request is being automatically deployed with now-deployment

Built with commit bf0fecfc98a3c2283df57a6573cd5c5ba196b983

✅ Preview: https://guide-preview-13xpnsni0.now.sh

rousik commented 4 years ago

I have reverted the changes to _scripts/import_resources.py so that this can be merged into master independently of the other PR.

rousik commented 4 years ago

@jaysonvirissimo, @emersonthis and/or @mverzilli - please approve.

github-actions[bot] commented 4 years ago

This pull request is being automatically deployed with now-deployment

Built with commit 8e6d58de9443b608433573946fe381e91b8daa1d

✅ Preview: https://guide-preview-h8lyldymq.now.sh

emersonthis commented 4 years ago

I added the "on hold" label to signal that this shouldn't be merged until #305 is merged.

rousik commented 4 years ago

I made this actually independent PR that can be merged as-is w/o having to wait for the other one

On Sun, Apr 5, 2020, 14:22 emersonthis notifications@github.com wrote:

I added the "on hold" label to signal that this shouldn't be merged until

305 https://github.com/flattenthecurve/guide/pull/305 is merged.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/flattenthecurve/guide/pull/306#issuecomment-609476542, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYSCGD6JQFUSXKZJSEG7MLRLDSA7ANCNFSM4MBIDZTQ .