search

flattenthecurve / guide

https://www.flattenthecurve.com
Creative Commons Attribution 4.0 International
38 stars 33 forks source link

re-introduce exclude_from_nav for #303 #319

Closed brian-bot closed 4 years ago

brian-bot commented 4 years ago

fixes #303

github-actions[bot] commented 4 years ago

This pull request is being automatically deployed with now-deployment

Built with commit 89171f4eed83f4b49c5d7c01189eb35c008612e1

✅ Preview: https://guide-preview-1ibqlszvc.now.sh

brian-bot commented 4 years ago

not sure how all of the other index-.md files get processed with lokalise (or otherwise) so the exclude_from_nav might need to be added manually to all of those files as well

mverzilli commented 4 years ago

We merged another fix for this, however this one seems a bit more elegant. @brian-bot if you don't mind fixing the conflicts and removing that change we can merge this.

brian-bot commented 4 years ago

conflicts fixed

github-actions[bot] commented 4 years ago

This pull request is being automatically deployed with now-deployment

Built with commit 077d92a58d6563157887bbd6d79636d48bd17223

✅ Preview: https://guide-preview-2xqiycfgf.now.sh

mverzilli commented 4 years ago

@brian-bot thanks! I think we still need update the exclude_from_nav attribute in the index-*.md file for each language, otherwise the issue continues to happen in languages other than English (check German or Italian in the preview, for example).

github-actions[bot] commented 4 years ago

This pull request is being automatically deployed with now-deployment

Built with commit 6cbd45e69e419f959cda6b5da25551b7da457122

✅ Preview: https://guide-preview-ce9pqg64o.now.sh

mverzilli commented 4 years ago

Awesome, thank you!