search

flattenthecurve / guide

https://www.flattenthecurve.com
Creative Commons Attribution 4.0 International
38 stars 33 forks source link

Add scientific review needed include #349

Closed kendrahavens closed 4 years ago

kendrahavens commented 4 years ago

Hello! I'm new here so feel free to disregard this PR if it is not aligned with your best practices or you'd prefer a different solution. :)

Addresses part of https://github.com/flattenthecurve/guide/issues/318

By simply adding the include disclaimer below to any post in act_and_prepare

{:.disclaimer}
{% include disclaimer/en/disclaimer.md %}

The following notes can appear:

  1. Needs scientific review note at the top of the page image

  2. Needs scientific review note individual sections (posts) image

If approved, all the disclaimer.md files would need translations into the target language.

This PR does not address the other needs mentioned in the linked issue:

nditada commented 4 years ago

@kendrahavens Thanks for the contribution, but the .mds for translations are generated automatically from Lokalise. Plus what we need is a way of showing that note conditionally, depending on the status of the verification of the translation. The styling is perfect.

kendrahavens commented 4 years ago

Makes sense! I didn't take the lokalise generation into account. I'll close this and think a bit more on that.

rousik commented 4 years ago

The style and the message is great. We can keep just the English version and let the lokalise do the translations for us.

I'm also thinking that sci review may be per-advice on the what-to-do page but may be on a per-page for other parts of the site (e.g. Covid-19 section)

On Wed, Apr 15, 2020, 18:37 Kendra Havens notifications@github.com wrote:

Makes sense! I didn't take the lokalise generation into account. I'll close this and think a bit more on that.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/flattenthecurve/guide/pull/349#issuecomment-614348197, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYSCGAKKPCG36ZJS3SUEBTRMZHN7ANCNFSM4MIJ5GLQ .