search

flattenthecurve / guide

https://www.flattenthecurve.com
Creative Commons Attribution 4.0 International
38 stars 33 forks source link

Few improvements to the language import script #375

Closed rousik closed 4 years ago

rousik commented 4 years ago

Mainly around pending-sci-review noticiations.

  1. Script crashed for languages that did not have any keys in the reviewed state. This is now fixed.
  2. I have consolidated indentation to be 2 spaces everywhere (cosmetic fix only).
  3. Removed --[no-]sci-review-notice commandline flag and replaced with more flexible configuration block in the _config.yml. This allows us to fine tune where we want these notices to be shown.
  4. Move the decision logic for whether the notice should be shown into its own function for better readability.
  5. Do not show notices in the section header files in act_and_prepare (these were introduced in PR #336)
github-actions[bot] commented 4 years ago

This pull request is being automatically deployed with now-deployment

Built with commit 485f57215f50c2724bd09ca9437cd464faed68b2

✅ Preview: https://guide-preview-dz5rak90n.now.sh