flattenthecurve / guide

https://www.flattenthecurve.com
Creative Commons Attribution 4.0 International
38 stars 33 forks source link

Change the logic for displaying sci review notices #381

Closed rousik closed 4 years ago

rousik commented 4 years ago

Until now, the pending-sci-review notice was included or not during the language import and this decision was based on the configuration in _config.yml. I have decided to make this a bit more flexible, always include the notice include in the markdown files and make the notice smarter and read the configuration and decide whether it should render the snippet or nothing. This will allow us to turn this on and off without having to rerun the language import from lokalise which I think is a better approach.

github-actions[bot] commented 4 years ago

This pull request is being automatically deployed with now-deployment

Built with commit 26f35f2f2c36f9370e6559372ce596e0f817c59c

✅ Preview: https://guide-preview-g9k3bfri2.now.sh

rousik commented 4 years ago

In order to speed things up I have bundled this with a flag-flip that enables pending-sci-notices for all languages by default. This should take effect next time translations are synced with head.

github-actions[bot] commented 4 years ago

This pull request is being automatically deployed with now-deployment

Built with commit 276a4fe5e2ccb7e5d428b1e48567f772e0f81eb6

✅ Preview: https://guide-preview-db66z5ec0.now.sh