search

flattenthecurve / guide

https://www.flattenthecurve.com
Creative Commons Attribution 4.0 International
38 stars 33 forks source link

Update _content/es from Lokalise #398

Closed rousik closed 4 years ago

rousik commented 4 years ago

@monicacecilia, feel free to check the preview build to make sure everything looks good.

monicacecilia commented 4 years ago

Hi @rousik, thanks for the heads up. I had a look and the preview site looks ok. All content is being displayed as it was intended in the last round on Lokalise. I figured out the switch for the svg magic and all images are now being displayed again. I see that the build is failing a check (up there ^^), but I, of course, leave that to the site experts. :bowtie: All good from my end! Thanks again! 🌺

rousik commented 4 years ago

Looks like build_and_deploy uses some fixed-naming-magic that is broken, @bcardiff fyi.

bcardiff commented 4 years ago

It seems more an issue of configuration of the secrets in the project. But it's odd since those didn't change.

compare https://github.com/flattenthecurve/guide/runs/647412560?check_suite_focus=true#step:5:34 and https://github.com/flattenthecurve/guide/runs/675431429?check_suite_focus=true#step:5:49

Yet, the deployment of this PR is available at https://guide-preview-fqj3j3ait.now.sh/

rousik commented 4 years ago

@bcardiff I don't think this has to do with secrets because the preview is pushed to vercel, but script then fails to retrieve the deployment url.

I have opened #402 to track this problem. My prime suspect is that version upgrade of now cli causes this.