search

flattr / flattr-extension

Flattr web extension - monetize your content effortlessly.
https://flattr.com
GNU General Public License v3.0
27 stars 5 forks source link

Issue #29 - Download updates to the domains list #30

Closed erikvold closed 6 years ago

erikvold commented 6 years ago

Note: The tests are failing for some reason(s), it's not the new tests that were added, they seem to work on their own, but I seem to have broken other tests somehow, it looks related to the fact that the new saga that I've added uses chrome.storage.local which sinon-chrome doesn't provide a shim for, so I might have to update that dependency first. I need to look in to this some more.

erikvold commented 6 years ago

@ThomasGreiner finally got these tests passing, the issue was that the saga would be triggered when we tested other modules, so there were all kinds of different failures happening in the background. I was able to resolve this by only running/including all of the sagas in the chrome environment (thus avoiding the nodejs test environment), so now if the tests depend on a saga then we have to make sure it is available and running explicitly in the test(s).

As a result I had to rewrite the domains-task module to be a saga, which I think is better than the previous code which was made in a rush (when I didn't realize how to make the alarm/task in to a saga), but that was basically required to get the tests working.

erikvold commented 6 years ago

@ThomasGreiner hey I think this is ready for another review now.

erikvold commented 6 years ago

https://files.smickr.net/domains.json is live btw so you could change this.

@leihog when I try this url I get an error.