search

flaupretre / pecl-pcs

PHP Code Service
Other
25 stars 4 forks source link

Fails to install in PHP 7.4.6 #12

Closed josev814 closed 4 years ago

josev814 commented 4 years ago

When attempting to install in Debian Buster PHP 7.4 pcs-1.3.3 fails to install. I've tested in PHP 7.2 and 7.3 and they install correctly. https://github.com/flaupretre/pecl-pcs/blob/84470b9d2d1b25e2171417bf076f553e65d23b39/src/PCS_Loader.c#L248

The error output is:

/tmp/pear/temp/pcs/src/PCS_Stream.c:35:2: note: (near initialization for 'pcs_dirops.read')
In file included from /tmp/pear/temp/pcs/php_pcs.c:92:
/tmp/pear/temp/pcs/src/PCS_Loader.c: In function 'PCS_Loader_loadNode':
/tmp/pear/temp/pcs/src/PCS_Loader.c:248:21: error: 'union <anonymous>' has no member named 'fd'; did you mean 'fp'?
  file_handle.handle.fd = 0;
                     ^~
                     fp
make: *** [Makefile:216: php_pcs.lo] Error 1
ERROR: `make' failed
The command '/bin/sh -c pecl install pcs-1.3.3
jefflaplante commented 4 years ago

I have this same exact issue with php 7.4.6 on the official docker image.

flaupretre commented 4 years ago

OK. I'm working on the issue

flaupretre commented 4 years ago

Need to fix tests

josev814 commented 4 years ago

I tried running all of the unit tests, and only php 5.6 was passing on Travis CI. I had it test against 5.6-7.4 and nightly.

josev814 commented 4 years ago

From what I saw in php 7.3 it would install, but would result in a segfault doing php -a or running pecl list after enabling it.

flaupretre commented 4 years ago

OK. Thanks for the information. I will check it all starting with 5.6.

flaupretre commented 4 years ago

Everything seems to be OK now.