search

flauschtrud / broccoli

Broccoli is a free recipe app that lets you build your own personal recipe collection and helps you cook in a more eco-friendly way.
GNU General Public License v3.0
76 stars 8 forks source link

F-Droid reproducible build failed #250

Closed linsui closed 4 months ago

linsui commented 4 months ago

https://gitlab.com/fdroid/fdroiddata/-/jobs/7252061841 The content of the apk is identical but the apk is different. Is there anything changed?

flauschtrud commented 4 months ago

What do you mean exactly by identical but different?

This is the changelog for the f-droid Release: https://github.com/flauschtrud/broccoli/compare/v1.2.10-fdroid...v1.2.11-fdroid

The majority of changes concerns translations. There are some small bug fixes, but I also updated all dependencies including Gradle:

Might there be any known issues regarding this Gradle version? I'm wondering because I remember that there have been some Gradle-specific issues when I first setup the app for deployment on f-droid.

licaon-kter commented 4 months ago

We're narrowed it down to: https://gitlab.com/fdroid/fdroiddata/-/issues/3299

Eg. https://github.com/flauschtrud/broccoli/blob/master/.github/workflows/fdroid-release.yml#L8

So instead of sign from BUILD_TOOLS_VERSION, do use apksigner from 34.0.0

licaon-kter commented 4 months ago

@flauschtrud or don't use 34, keep it like that, but make it do apksigner sign --alignment-preserved true ...

licaon-kter commented 4 months ago

Based on the docs here: https://github.com/obfusk/apksigcopier#what-about-signatures-made-by-apksigner-from-build-tools--3500-rc1

I've updated the recipe instead: https://gitlab.com/fdroid/fdroiddata/-/commit/1d7967b75bcde8c716206b803cb404a8b4833f30

feel free to star the Google issue https://issuetracker.google.com/issues/351408623

/close this

flauschtrud commented 4 months ago

@linsui @licaon-kter Sorry for getting back so late and thanks a lot for your investigations!