search

flauwekeul / honeycomb

Create hex grids easily, in node or the browser.
https://abbekeultjes.nl/honeycomb
MIT License
639 stars 59 forks source link

feature: pathfinder traverser #122

Closed szikoramarci closed 1 month ago

szikoramarci commented 2 months ago

I implemented a new feature: pathfinder traverser that is based on A* algorythm.

The basic description of the feature is on redblobgames.com https://www.redblobgames.com/pathfinding/a-star/implementation.html#algorithm

flauwekeul commented 1 month ago

As you may have seen, I also have an example in the examples folder of A* pathfinding 😄 But it's using the abstract-astar library. Would it be okay for you to also use this (or some other lib) instead of adding it as a traverser to Honeycomb? I'm not sure pathfinding qualifies as a traverser. There are many ways to "pathfind" and if I add one algorhythm, why shouldn't I add more algorhythms? I prefer to keep honeycomb's API "open" enough for people to use these kinds of algorhythms themselves, instead of adding the algorhythms to the lib.

szikoramarci commented 1 month ago

Yeah. I saw that. I've got your point and I can accept it :)

Honestly, I wasn't really sure about this function is a traverser, or not. My decision was based on the result, because we got a path which can be gone through. Other point is: I wanted to understand it and to have more control what the function doing and returning.

So, I would use that function for my project separately from the honeycomb-grid. Yeah, keep it real ang keep it clear.

Feel free to close that PR without merging ;)

And thanks again for that great stuff you did. Once I would show you what I implemented basd on honeycomb-grid :)

flauwekeul commented 1 month ago

Thanks for the compliment 😊 I'll close the PR then. And let me know what you made 👍