flauwekeul / honeycomb

Create hex grids easily, in node or the browser.
https://abbekeultjes.nl/honeycomb
MIT License
630 stars 57 forks source link

bail logic is backwards in traverse()? #84

Closed etodanik closed 2 years ago

etodanik commented 2 years ago

https://github.com/flauwekeul/honeycomb/blob/5fb3fd1bd7c6e0755567e6f1d784d46b295efc98/src/grid/grid.ts#L107

It seems to me that right now the intended logic is backwards? If bail = true it won't bail, if bail = false it will.

flauwekeul commented 2 years ago

Good catch 🎣 . Fixed it in next.

I keep postponing to write tests. I shouldn't wait too long 🙈

flauwekeul commented 2 years ago

:tada: This issue has been resolved in version 4.0.0-beta.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: