flav-io / flavio

A Python package for flavour physics phenomenology in the Standard model and beyond
http://flav-io.github.io/
MIT License
71 stars 61 forks source link

Fixing calculation of BR(KL,KS->emu,mue) #141

Open hoodyn opened 3 years ago

hoodyn commented 3 years ago

This is the (second) pull request aiming to fix the problems in calculations od LFV kaon decays to leptons, based on discussion in #138. (I'm aborting my original PR #140 which I polluted by bugs and wrong argumentation.)

hoodyn commented 3 years ago

Summary of the issues being solved and proposed changes: Issues: 1: Call for a prediction of 'BR(KS->emu,mue)' was giving an error due to a bad implementation. 2: BR(KL->emu,mue) was calculated incorrectly, since simplified formulas were used which hold only for LF conserving cases.

Suggested updates

  1. K='KS', l1='e', l2='mu' is no longer an invalid combination of options in the function amplitudes_eff.

  2. Amplitudes for LFV decays (i.e. l1!=l2) were not calculated correctly. Fixing the physics required some nontrivial extension of the code:

Furthermore, I made an additional small commit:

  1. The function amplitudes_LD(par, K, l) was originally giving long-distance contributions for both 'KL' and 'KS', although it takes K as an argument. Eventually, everything had been calculated correctly but the implementation seemed little awkward to me. So I've changed it in order to make things clearer.
coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.07%) to 93.798% when pulling 0c1865b6f3a50911b90722a175140d96acfc0e62 on hoodyn:Kll-repair into 011236d3c7efe070e987a851e161a3a663a2e62e on flav-io:master.

hoodyn commented 3 years ago

Here's my notes about the leptonic kaon decays in EFT. (I haven't found any suitable text in the literature.) Might be helpful to understand the changes in the implementation. kaon_decays.pdf

peterstangl commented 3 years ago

@hoodyn thank you again for all the work you have put into this! Since your results differ from those in published papers, I think it would be good to do some cross checks before merging this PR. Unfortunately, I don't have enough time at the moment to do that. So I will keep this PR open until I find time for this or somebody else can do some cross checks. Did you actually contact the authors of the paper that seems to contain mistakes?

hoodyn commented 3 years ago

@peterstangl Hi, I haven't contacted the authors of 1602.00881. I think that the mistakes in that paper can be qualified just as "big typos". This paper does not give formulae for KL,KS -> emu anyway, so I don't think it is important for this PR.

Btw, I used my branch of flavio to successfully crosscheck predictions of Ref. 1801.02895. The same crosscheck fails for the current master branch. This, however, says nothing about the problems I see in Ref. 1602.00881.

@hoodyn thank you again for all the work you have put into this! Since your results differ from those in published papers, I think it would be good to do some cross checks before merging this PR. Unfortunately, I don't have enough time at the moment to do that. So I will keep this PR open until I find time for this or somebody else can do some cross checks. Did you actually contact the authors of the paper that seems to contain mistakes?

peterstangl commented 2 years ago

Here's my notes about the leptonic kaon decays in EFT. (I haven'tfound any suitable text in the literature.) Might be helpful to understand the changes in the implementation. kaon_decays.pdf

@hoodyn I cross-checked your notes and found overall agreement. I found a few disagreements, which are, however, probably just typos. Nevertheless, I list them in the following:

Concerning the implementation, I will comment directly on the code.