align single and multi thread calculations of SM covariance

flav-io / flavio

A Python package for flavour physics phenomenology in the Standard model and beyond

http://flav-io.github.io/

MIT License

71 stars 62 forks source link

align single and multi thread calculations of SM covariance #47

Closed peterstangl closed 6 years ago

coveralls commented 6 years ago

Coverage increased (+0.08%) to 90.619% when pulling 5b7f7a2ec7b96bfb536e783f85c99c465cea9627 on peterstangl:sm_cov_multi_thread into 6eded9d7c77f3bb95c291ab4d8409642f76ca0ce on flav-io:master.

peterstangl commented 6 years ago

@DavidMStraub, it's not clear to me why test_measurements_yaml fails. How can just adding a new test affect any other test? Running nosetests locally on my machine, all tests pass.

DavidMStraub commented 6 years ago

What happens is that make_measurement creates a new instance of Measurement (for the pseudo measurement) and this instance for some reason does not pass a test in test_classes.py where the instance is converted to YAML and read back in. Probably it would be best to just skip measurements containing the string Pseudo-measurement in test_classes.py (where also the pathological case 'Belle B->D*lnu hadronic tag 2017' is being skipped).

DavidMStraub commented 6 years ago

Sorry, forgot to merge this.

Thanks!