search

flav1972 / ArduinoINA219

An Arduino library for the INA219 I2C current monitor
17 stars 16 forks source link

Changing the encoding from windows to UTF-8 #2

Closed ulysse314 closed 5 years ago

ulysse314 commented 5 years ago

Hello,

I would like to suggest to move to UTF-8. It is a bit more generic for all platform. I have no problem if you prefer to refuse my pull request :).

thanks

ulysse314 commented 5 years ago

Thinking about it, I'm not even sure why we need non-ASCII characters...

flav1972 commented 5 years ago

Me neither. Aller text is ascii

Le jeu. 14 févr. 2019 à 09:06, ulysse314 notifications@github.com a écrit :

Thinking about it, I'm not even sure why we need non-ASCII characters...

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/flav1972/ArduinoINA219/pull/2#issuecomment-463531074, or mute the thread https://github.com/notifications/unsubscribe-auth/ADLSgTbh5SyrhScv1-AoIrpj-8sDthK6ks5vNRkDgaJpZM4a4NSQ .

ulysse314 commented 5 years ago

Let me update this pull request... Thanks.

ulysse314 commented 5 years ago

Done

ulysse314 commented 5 years ago

The "–" is not an ascii character. This is not "-".

flav1972 commented 5 years ago

Reading this on my phone. I haven't seen that it is a "long minus ". We can use the normal one. The second in your message.

Le ven. 15 févr. 2019 à 02:35, ulysse314 notifications@github.com a écrit :

The "–" is not an ascii character. This is not "-".

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/flav1972/ArduinoINA219/pull/2#issuecomment-463872658, or mute the thread https://github.com/notifications/unsubscribe-auth/ADLSgaz3SQ-qOKz20bx9QfzlixqO0hZrks5vNg7wgaJpZM4a4NSQ .