Create logger and use it throughout the template

flaviait / ng2-jspm-template

A template for a quick development workflow with angular 2 and jspm

MIT License

14 stars 3 forks source link

Create logger and use it throughout the template #31

Closed svi3c closed 8 years ago

svi3c commented 8 years ago

I also created a PR for the chokidar socket emitter to disable the logs: https://github.com/capaj/chokidar-socket-emitter/pull/28 When this is merged, we don't have the events logged to the console without our logger. I think we can hook into the watcher and log the events in our own style.

Resolves #27

@DorianGrey

DorianGrey commented 8 years ago

Most of this lgtm. However:

As long as the external PR is not merged, we would have duplicate output for the socket emitter. I'd suggest to wait for the merge, or depend on your PR-branch until then.
A lot of this logger stuff reminds mind of logging tools like log4js-node or winston. I'm not sure if we would unnecessarily "reinvent the wheel" by not using of these.

svi3c commented 8 years ago

I'll go for log4js then.