search

flaviait / ng2-jspm-template

A template for a quick development workflow with angular 2 and jspm
MIT License
14 stars 3 forks source link

Use a shared module for common imports and setup stuff. #41

Closed DorianGrey closed 7 years ago

DorianGrey commented 7 years ago

Extracted from https://github.com/flaviait/ng2-jspm-template/pull/38 .

This commit moves the code towards using a SharedModule for commom imports, i.e. the CommonModule, FormsModule and TranslateModule. It also changes the import of BrowserModule to CommonModule whereever possible, since the first should only be imported by the application root.

In addition, providing the translations to TranslateService is also part of the shared module, since it's not used as a component itself and thus more suitable here.

@svi3c