search

flaviait / ng2-jspm-template

A template for a quick development workflow with angular 2 and jspm
MIT License
14 stars 3 forks source link

Use ngrx router instead of the deprecated router #7

Closed svi3c closed 8 years ago

svi3c commented 8 years ago

@zenhunt Fixes #2

DorianGrey commented 8 years ago

Apart from the already known TypeError in both dev-bundle and dist-bundle

TypeError: Path must be a string. Received undefined
      at assertPath (path.js:7:11)
      at Object.dirname (path.js:1324:5)
      at /home/linne/Dev/ng2-jspm-template/jspm_packages/npm/systemjs-plugin-babel@0.0.9/systemjs-babel-node.js:6645:38
      at /home/linne/Dev/ng2-jspm-template/jspm_packages/npm/systemjs-plugin-babel@0.0.9/systemjs-babel-node.js:6661:24
      at Array.map (native)
      at OptionManager.resolvePresets (/home/linne/Dev/ng2-jspm-template/jspm_packages/npm/systemjs-plugin-babel@0.0.9/systemjs-babel-node.js:6650:22)
      at OptionManager.mergePresets (/home/linne/Dev/ng2-jspm-template/jspm_packages/npm/systemjs-plugin-babel@0.0.9/systemjs-babel-node.js:6640:12)
      at OptionManager.mergeOptions (/home/linne/Dev/ng2-jspm-template/jspm_packages/npm/systemjs-plugin-babel@0.0.9/systemjs-babel-node.js:6616:16)
      at OptionManager.init (/home/linne/Dev/ng2-jspm-template/jspm_packages/npm/systemjs-plugin-babel@0.0.9/systemjs-babel-node.js:6732:12)
      at File.initOptions (/home/linne/Dev/ng2-jspm-template/jspm_packages/npm/systemjs-plugin-babel@0.0.9/systemjs-babel-node.js:7375:77)
      at new File (/home/linne/Dev/ng2-jspm-template/jspm_packages/npm/systemjs-plugin-babel@0.0.9/systemjs-babel-node.js:7319:24)
      at Pipeline.transform (/home/linne/Dev/ng2-jspm-template/jspm_packages/npm/systemjs-plugin-babel@0.0.9/systemjs-babel-node.js:3923:18)
      at /home/linne/Dev/ng2-jspm-template/jspm_packages/npm/systemjs-plugin-babel@0.0.9/plugin-babel.js:154:24
  Error loading /home/linne/Dev/ng2-jspm-template/jspm_packages/github/KevCJones/plugin-scss@0.2.11/index.js

it works as expected. But since this has nothing to do with this commit (fails on master as well)... LGTM.

svi3c commented 8 years ago

Thanks for the review, @DorianGrey. I just created https://github.com/KevCJones/plugin-scss/issues/14 for the bundling error.