search

flavio / qjson

QJson is a qt-based library that maps JSON data to QVariant objects.
http://qjson.sourceforge.net
GNU Lesser General Public License v2.1
288 stars 140 forks source link

Fix numbers parsing #107

Closed drizt closed 5 years ago

drizt commented 6 years ago

strtoll and strtoull may not reset errno for valid input. Need to check actual returned value as sayed in strtoll documentation.

Fix #48

drizt commented 6 years ago

I compiled my Torrent File Editor with this patch. So now no problems with number, please look this task drizt/torrent-file-editor#75

flavio commented 6 years ago

Everything LGTM. Could you please extend the test suite to ensure these corner cases are covered as well?

drizt commented 6 years ago

https://github.com/flavio/qjson/pull/107/commits/b9e1b711804fc28f1da7471d205a526015a3d261#diff-d3e03ec51bab3c39eb0e79a94309e692R292

drizt commented 6 years ago

Updated

drizt commented 5 years ago

Any progress here?

drizt commented 5 years ago

thanks!