Cannot build with Qt version < 4.4

flavio / qjson

QJson is a qt-based library that maps JSON data to QVariant objects.

http://qjson.sourceforge.net

GNU Lesser General Public License v2.1

288 stars 140 forks source link

Cannot build with Qt version < 4.4 #73

Closed rudilee closed 9 years ago

rudilee commented 9 years ago

I can't compile qjson with Qt 4.2.1, there is no QT_BEGIN_NAMESPACE and QT_END_NAMESPACE macros and no QRunnable interface which is according to Qt's doc introduced in Qt 4.4, perhaps the Qt version requirement in the README need to be corrected to "Qt 4.4 or greater"?

flavio commented 9 years ago

fixed with 7fd4b564017aa2e9611efd242a735fe317f67842

rudilee commented 9 years ago

I'm sorry, i kinda overlook the failure messages when compiling with Qt 4.2.1, looking further to the failures messages, there's complain about no QVariantHash in Qt 4.2.1, according to Qt's doc it's introduced in Qt 4.5.