search

flaviodelgrosso / electron-forge-react-vite-boilerplate

Electron Forge boilerplate with React and powered by Vite.js
MIT License
26 stars 5 forks source link

Support for ESM #2

Open lbassani12 opened 1 month ago

lbassani12 commented 1 month ago

Hi Flavio!

I've recently started a proyect with this boilerplate and it's fantastic. But I've stumble upon a problem when trying to use ESM pure packages, such as electron-store.

Why have you decided to go with commonJS instead of ESM?

Do you have in mind migrating to ESM?

Thanks a lot!

Cheers

flaviodelgrosso commented 1 month ago

Hi Flavio!

I've recently started a proyect with this boilerplate and it's fantastic. But I've stumble upon a problem when trying to use ESM pure packages, such as electron-store.

Why have you decided to go with commonJS instead of ESM?

Do you have in mind migrating to ESM?

Thanks a lot!

Cheers

Hi @lbassani12

Thank you so much for your feedback—it’s greatly appreciated!

The decision to go with CJS isn't entirely mine. Encountered several challenges with ESM, including issues like the one discussed here https://github.com/electron/forge/issues/3439.

That said, I’ll definitely give a look at it to handle your needs.