search

flaviogrossi / sockjs-cyclone

SockJS server support for the Cyclone web server
MIT License
26 stars 4 forks source link

Expose User-Agent header in ConnectionInfo #7

Closed slauwers closed 10 years ago

slauwers commented 10 years ago

This PR allows the User-Agent header to be exposed by the ConnectionInfo class.

An alternative possibility would be to allow the library user to specify additional headers to expose via an optional dictionary in get_conn_info(), which could then be passed to the ConnectionInfo constructor.

If you prefer this alternative method, please let me know and I will update the PR.

flaviogrossi commented 10 years ago

Thank you for you contribution!

If you need an updated version to be published on pypi, just let me now.

slauwers commented 10 years ago

Hi Flavio,

We're good; we package our own RPMs, and always take directly from github. I'll email our developers to update their local install not through pip but from master.

Thanks,

-S.