flavioribeiro / nginx-audio-track-for-hls-module

:sound: Nginx module that generates audio track for HTTP Live Streaming (HLS) streams on the fly.
GNU General Public License v3.0
136 stars 17 forks source link

Add support for select output format #24

Closed jalonsoa closed 9 years ago

jalonsoa commented 9 years ago

Hi, this patch add support for select output format (not only predefined adts)

Add 2 new configuration options ngx_hls_audio_track_output_format: format to the ouput, for av_guess_format. To show supported formats in your library use "ffprobe -formats". ngx_hls_audio_track_output_header: content type header added to return (audio/aac, video/MP2T, etc ).

flavioribeiro commented 9 years ago

hi @jalonsoa thanks for this. Can you add some lines of documentation on README regarding this new instructions before I merge?

jalonsoa commented 9 years ago

Of course ... a moment ..

I try to see your testing tools, to create test about this new feature, but I don't understand where get the config of nginx. Can you create the test about this ?

j

On Wed, Jan 14, 2015 at 1:42 PM, Flávio Ribeiro notifications@github.com wrote:

hi @jalonsoa https://github.com/jalonsoa thanks for this. Can you add some lines of documentation on README regarding this new instructions before I merge?

— Reply to this email directly or view it on GitHub https://github.com/flavioribeiro/nginx-audio-track-for-hls-module/pull/24#issuecomment-69910652 .

flavioribeiro commented 9 years ago

Yes, when I have time I'll close another issue and take this opportunity to write tests for this feature also

jalonsoa commented 9 years ago

Hi Flavio, I add more info and one example. Can you check it ?

flavioribeiro commented 9 years ago

hi @jalonsoa, thanks for this contribution. This module is being used in production for some time here at Globo.com, can you tell me where you're trying to use it? :beers:

jalonsoa commented 9 years ago

Hi Flavio, you are welcome. Thanks for this module.

We use nginx-rtmp module for 2 years here at Unidad Editorial (elmundo.es, marca.com) and we needed this part to audio streams work fine in android (nginx-rtmp need video stream to generate hls fragments, so our hls have audio and video streams and android >4.4.3 need only audio into the streams for mediaplayer)

thanks j

On Wed, Jan 14, 2015 at 4:45 PM, Flávio Ribeiro notifications@github.com wrote:

hi @jalonsoa https://github.com/jalonsoa, thanks for this contribution. This module is being used in production for some time here at Globo.com, can you tell me where you're trying to use it? [image: :beers:]

— Reply to this email directly or view it on GitHub https://github.com/flavioribeiro/nginx-audio-track-for-hls-module/pull/24#issuecomment-69935825 .

flavioribeiro commented 9 years ago

awesome! happy to see this project being used at El Mundo and Marca :-) Thank you!