search

flaviostutz / ruller-dsl-feature-flag

A feature flag engine that can be used to enable, change or rollout features of a system dynamically based on system or user attributes
MIT License
2 stars 6 forks source link

Changed staticAttributeCode var name generation #26

Open Rhuancpq opened 2 years ago

Rhuancpq commented 2 years ago

In order to solve bug described in this issue, I've changed the logic of naming vars in rules code creation.

Now the function considers both depth and breadth, not only depth, and bind parentVar name across recursion calls

flaviostutz commented 2 years ago

Hi! Have you tested this code?

Rhuancpq commented 2 years ago

I've tested the code generation, but not tested running with base ruller

reinaldocomputer commented 2 years ago

I took a look, good solution for this problem.

Merry Christimas!