This PR provides compatibility with TagLib 2.0 by changing from a previously deprecated API to the already available replacement.
replace MP4::ItemListMap by TagLib::MP4::ItemMap
replace MP4::Tag::itemListMap() by MP4::Tag::itemMap()
add version requirement for TagLib >= 1.10 in README.md
add an include for iostream in mainWindow.cpp to be sure that std::cout is available.
The new API type and function have been added to TagLib with version 1.10 on 04.12.2015. The change to the new API therefore does not break building musique with any TagLib version >= 1.10.
The missing include for iostream led to a compile error on openSUSE Leap 15.5. It may depend on the environment whether this is necessary, but it is anyway good practice to include this explicitly when it is used in the compile unit.
flaviotordini
commented
8 months ago
This PR provides compatibility with TagLib 2.0 by changing from a previously deprecated API to the already available replacement.
MP4::ItemListMapbyTagLib::MP4::ItemMapMP4::Tag::itemListMap()byMP4::Tag::itemMap()README.mdiostreaminmainWindow.cppto be sure thatstd::coutis available.The new API type and function have been added to TagLib with version 1.10 on 04.12.2015. The change to the new API therefore does not break building
musiquewith any TagLib version >= 1.10.The missing include for
iostreamled to a compile error on openSUSE Leap 15.5. It may depend on the environment whether this is necessary, but it is anyway good practice to include this explicitly when it is used in the compile unit.closes #53