search

flavono123 / identicon

A Python library for generating Github-like identicons 👾
MIT License
30 stars 9 forks source link

import Identicon issue #3

Open McPo opened 6 years ago

McPo commented 6 years ago

There appears to be an issue with importing the library from pypi via pip and virtualenv. Note, I can install other libraries and import them fine. So Im fairly certain the issue is with this library.

McPo commented 6 years ago

The issue is caused by what appears to be a mix of two different python libraries.

You have placed the library on at 0.1 The latest code change suggests the version is really 0.1.1

However there is an Identicon==1.0. And it appears to be causing issues. Might be best to bump the library to 1.1 at least.

https://pypi.org/project/identicon/#history

flavono123 commented 6 years ago

I knew about it.

I've got the pip name as Identicon on followed thread: https://github.com/shnjp/identicon/issues/2

To bump the version 1.1, I think we have to set some features for that milestone then develop them. You've done about that work, version 0.2.0 (Thanks for contribution, btw 😄)

One of the features would be 'not overlap the foreground color and the background color' I think(Critical .. we can see the identicon!).