Add multiline messages and messages from file

flavorjones / irc-notification-resource

Concourse CI resource for sending notifications to IRC.

Other

4 stars 2 forks source link

Add multiline messages and messages from file #16

Closed avanier closed 4 years ago

avanier commented 4 years ago

This PR adds the following:

The ability to take a message from a file or from the param.
The ability to send multiline messages as a sequence of messages
Adds some safety features to the integration test script
Version pins Alpine in the Dockefile
Cleans the image on build to expand compatibility to OCI image builders that don't respect .dockerignore

flavorjones commented 4 years ago

Thanks for submitting this! I'm going to make some comments on the commits.

avanier commented 4 years ago

Can I ask that commit 1ea78e4 go into a separate PR? I'd like to understand more deeply the problem you're solving, and this seems unrelated to the feature/functional parts of the PR.

The situation I was facing is I discovered that podman and buildah would ignore the the .dockerignore and stick my locally built artifacts in the build context and make test would fail with file not found due to dynamic linking errors.

As for the pinning of the image versions, it "fixes nothing" I was on a drive-by fix binge and it went in.

avanier commented 4 years ago

The Docker image commit has been moved to #17 .

avanier commented 4 years ago

Bump

flavorjones commented 4 years ago

@avanier Thanks for your patience. It's been hard to make time for open-source work lately. I'll schedule some time to work on this in the next few days.

flavorjones commented 4 years ago

I've added some test coverage and some other small changes, and merged this manually. Thank you for your contribution! I'll update the CHANGELOG to credit you and ship an update now.

flavorjones commented 4 years ago

v1.3.0 has been shipped with these features. Thanks again!