Closed avanier closed 4 years ago
Thanks for submitting this! I'm going to make some comments on the commits.
Can I ask that commit 1ea78e4 go into a separate PR? I'd like to understand more deeply the problem you're solving, and this seems unrelated to the feature/functional parts of the PR.
The situation I was facing is I discovered that podman
and buildah
would ignore the the .dockerignore
and stick my locally built artifacts in the build context and make test
would fail with file not found
due to dynamic linking errors.
As for the pinning of the image versions, it "fixes nothing" I was on a drive-by fix binge and it went in.
The Docker image commit has been moved to #17 .
Bump
@avanier Thanks for your patience. It's been hard to make time for open-source work lately. I'll schedule some time to work on this in the next few days.
I've added some test coverage and some other small changes, and merged this manually. Thank you for your contribution! I'll update the CHANGELOG to credit you and ship an update now.
v1.3.0 has been shipped with these features. Thanks again!
This PR adds the following:
param
..dockerignore