search

flavorjones / irc-notification-resource

Concourse CI resource for sending notifications to IRC.
Other
4 stars 2 forks source link

Add new params for UseTLS and Join #4

Closed ercollin closed 5 years ago

ercollin commented 6 years ago

Added 2 new params: 1) UseTLS so this can be disabled when connecting to an internal IRC server not using TLS 2) Join which will first Join the channel before posting the message, then leave it. Seems to be required on ngircd.

flavorjones commented 5 years ago

@ercollin Thank you for submitting this!

Sorry for my slow reply -- I didn't have notifications turned on so I just saw this now.

Give me a day or two to take a look at these changes and get CI set up. Thank you!

flavorjones commented 5 years ago

@ercollin I've rebased this commit against master on another branch, so don't worry about doing that. Should be able to merge this and cut a release in the next day or so.

flavorjones commented 5 years ago

Merged manually! Thank you for this contribution. I'll update the README and acknowledge you in the CHANGELOG (which I need to create!).

flavorjones commented 5 years ago

One quick note: I did make a subsequent commit to ensure that UseTLS continued to default to true. I would have considered that to be a breaking change.

Thanks again!

flavorjones commented 5 years ago

v1.1.0 has been shipped and is up on DockerHub. Let me know how it goes!