search

flavorjones / loofah

Ruby library for HTML/XML transformation and sanitization
MIT License
934 stars 138 forks source link

Update safelist.rb to include overflow-x and y #206

Closed sampokuokkanen closed 3 years ago

sampokuokkanen commented 3 years ago

Just run into the problem of overflow-x and y disappearing. It seems like the end-goal is to not to have to maintain a list like this, but at least in my use case overflow-y is used quite a bit. So it would be pretty great to have it as allowed property too!

sampokuokkanen commented 3 years ago

The tests seem to fail on main branch too (at least locally for me). Any ideas there? :thinking:

flavorjones commented 3 years ago

@sampokuokkanen Thanks for the PR! I'll take a look as soon as I have a bit of time.

The tests are likely failing because of Nokogiri's recent upgrade to libxml 2.9.12, please ignore that for now and I'll rebase your branch once that's fixed.

flavorjones commented 3 years ago

Rebased! Let's see what CI says now.

flavorjones commented 3 years ago

Cutting v2.9.10 now. Thank you for your contribution!