Closed flavorjones closed 3 years ago
Fixed in v2.5.2.
Hi, apologies if v2.4.0
is not supported but I couldn't find any info on supported versions.
While working on another package (asciidoctor), I noticed installing nokogiri@1.10.10
breaks on ruby 3.1 since it depends on mini_portile2@2.4.0
, which has this issue.
I'm not too familiar with ruby, but it seems this can be fixed:
nokogiri@1.10.11
with net-ftp
as a dependencynokogiri@1.10.11
using mini_portile2~>2.5.0
mini_portile2@2.4.1
with net-ftp
as a dependencyI'm not sure which fix would be best, but I'll be happy to open a PR in whichever repo it should go to.
Unless both nokogiri@1.10.10
and mini_portile2@2.4.0
are no longer supported, in which case I'll open an issue in asciidoctor.
Thanks.
Hi! Nokogiri v1.10 is not a supported version, since v1.11 was released in January 2021 (the current supported branch is v1.13.x). Please ask the asciidoctor maintainers to update the gemspec!
I actually did this while I had context swapped in: https://github.com/asciidoctor/asciidoctor/pull/4339
Hi @flavorjones
Nokogiri v1.10 is not a supported version, since v1.11 was released in January 2021
Got it.
I actually did this while I had context swapped in: https://github.com/asciidoctor/asciidoctor/pull/4339
Thanks!
When using mini_portile2 on Ruby 3.1.0.dev, we see this error:
Recent commits on Ruby master (e.g., https://github.com/ruby/ruby/commit/e49c998d1e41737016c8afb7e1b22797018caebb) moved the
net-*
set of libraries from the standard library to be bundled gems.I'm creating this issue to: