Closed brayanhenao closed 5 months ago
Thank you! I've kicked off CI and will take a closer look tomorrow.
@brayanhenao Thanks again for proposing this. After reading, my primary concern is that HTTP proxy credentials may be leaked into a log when used.
Would you be open to dropping that line from this PR? Alternatively, this might be a good time to introduce a debug
or verbose
option to the constructor's **kwargs
parameter. WDYT?
Bumping this, @brayanhenao did you want to try to make any of those changes?
Hi, @flavorjones I'll find some time this weekend/next week to make the change!
Closing this, though I'd be open to better error messages if @brayanhenao or someone else wants to pick this up.
Add outputs to the
download_file_http
function: