Add some useful outputs to debug errors

flavorjones / mini_portile

mini_portile and mini_portile2 - Simple autoconf and cmake builder for developers

MIT License

114 stars 51 forks source link

Add some useful outputs to debug errors #112

Closed brayanhenao closed 5 months ago

brayanhenao commented 2 years ago

Add outputs to the download_file_http function:

Print the URL from which the file is downloaded.
Print the parameters of the HTTP Call.
In the case there is an HTTP error, print the status and the body of it.

flavorjones commented 2 years ago

Thank you! I've kicked off CI and will take a closer look tomorrow.

flavorjones commented 2 years ago

@brayanhenao Thanks again for proposing this. After reading, my primary concern is that HTTP proxy credentials may be leaked into a log when used.

Would you be open to dropping that line from this PR? Alternatively, this might be a good time to introduce a debug or verbose option to the constructor's **kwargs parameter. WDYT?

flavorjones commented 1 year ago

Bumping this, @brayanhenao did you want to try to make any of those changes?

brayanhenao commented 1 year ago

Hi, @flavorjones I'll find some time this weekend/next week to make the change!

flavorjones commented 5 months ago

Closing this, though I'd be open to better error messages if @brayanhenao or someone else wants to pick this up.