Closed stanhu closed 1 year ago
Ack. CMake is still "experimental" and you may be the first person to really try to use it for something. Will take a look, but prioritizing it behind some other work at the moment.
It seems that https://github.com/flavorjones/mini_portile/blob/5084a2aeab12076f534cf0cabc81a4d5f84b5c25/lib/mini_portile2/mini_portile_cmake.rb#L17 isn't needed when cross-compiling in Linux, but the flag is needed in Windows.
While working on https://github.com/mudge/re2/pull/67, I found that the default cmake generator option for Windows builds did not work for the
abseil-cpp
project:I worked around the problem by pruning the
-G
option fromconfigure_options
, but it'd be nice to make it easier to skip this.